wms icon indicating copy to clipboard operation
wms copied to clipboard

[14][IMP] shopfloor: Ensure destination location on moves for allow move create

Open mt-software-de opened this issue 11 months ago • 5 comments

Ensure that the destination gets also set on the move. When a move is created within the single pack or single product transfer scenario, the move ends up with the default destination location of the operation type. To ensure that the destination location of the move gets also set, we need to set it also on the move not only on the move.line.

cc @jbaudoux @i-vyshnevska

mt-software-de avatar Jan 15 '25 15:01 mt-software-de

Hi @mmequignon, @simahawk, @sebalix, @guewen, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jan 15 '25 15:01 OCA-git-bot

What's the purpose of sync_src_location ? I updated the description.

mt-software-de avatar Jan 15 '25 15:01 mt-software-de

Without syncing the src location, the moves will end up with the warehouse view location as src location and with actual scanned location as dest location.

@mt-software-de Isn't it something that should be tackled at move creation? When you scan the source location and product/package to move, the move should be created on that location and not on the picking type source location. Same if you plan the moves, should be planned on the right source location.

jbaudoux avatar Jan 15 '25 16:01 jbaudoux

Without syncing the src location, the moves will end up with the warehouse view location as src location and with actual scanned location as dest location.

@mt-software-de Isn't it something that should be tackled at move creation? When you scan the source location and product/package to move, the move should be created on that location and not on the picking type source location. Same if you plan the moves, should be planned on the right source location.

I checked it again the source location was never be the problem. I was on allow move create the dest location on the move which was missing. And only for the single product transfer because there are no package level.

mt-software-de avatar Jan 21 '25 07:01 mt-software-de

cc @rousseldenis

jbaudoux avatar Jan 21 '25 09:01 jbaudoux

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 01 '25 12:06 github-actions[bot]

@jbaudoux @rousseldenis @mmequignon Could we move forward with this?

mt-software-de avatar Jun 22 '25 11:06 mt-software-de

@mt-software-de can you make one commit per module ?

jbaudoux avatar Jun 23 '25 06:06 jbaudoux

@mt-software-de can you make one commit per module ?

done

mt-software-de avatar Jun 23 '25 10:06 mt-software-de

/ocabot merge minor

jbaudoux avatar Jun 24 '25 14:06 jbaudoux

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-973-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot avatar Jun 24 '25 14:06 OCA-git-bot

Congratulations, your PR was merged at 78148010a0b05096e092b9bffd3ceccbb423aac7. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 24 '25 14:06 OCA-git-bot