wms
wms copied to clipboard
OCA
[14.0][IMP] shopfloor: add option to exclude package types in product info
Depends on:
- https://github.com/OCA/product-attribute/pull/1523
Qty picker:
Settings:
ref: cos-4389
Hi @guewen, @sebalix, @simahawk, some modules you are maintaining are being modified, check this out!
We should not add new dependencies in shopfloor. So those changes should move to a new module shopfloor_vendor_packaging (auto install glue between shopfloor and OCA/product-attribute#1523)
I thought you could transmit the option to the front and let the front manage the exclusion at https://github.com/OCA/wms/blob/14.0/shopfloor_mobile/static/wms/src/wms_utils.js#L328 without a global variable in the context. All those overrides to manage context seem fragile.
I've moved this to the new shopfloor_vendor_packaging module.
Regarding trasmitting the option to the front: as far as I understood it (and as far as I see it), we should not let the frontend decide these things. The qty picker will in the end display whatever the backend sends.
This will be valid only if this module is installed. I believe this has its place in
shopfloor, adding a default behavior: do not display vendor packages. Then, we add this option on the menus we want.
This module will be installed automatically when shopfloor is installed right? At least that's what I understand that happens when the auto-install flag is set to True.
This will be valid only if this module is installed. I believe this has its place in
shopfloor, adding a default behavior: do not display vendor packages. Then, we add this option on the menus we want.This module will be installed automatically when shopfloor is installed right? At least that's what I understand that happens when the
auto-installflag is set to True.
well, yes, you're right, I missed this.
@jbaudoux @simahawk any insight about this?
My thoughts are that shopfloor is meant implement incoming/outgoing/internal flows. To me it makes sense that this is a core feature. on the other hand, that would be another dependency. Thanks!
This will be valid only if this module is installed. I believe this has its place in
shopfloor, adding a default behavior: do not display vendor packages. Then, we add this option on the menus we want.This module will be installed automatically when shopfloor is installed right? At least that's what I understand that happens when the
auto-installflag is set to True.well, yes, you're right, I missed this.
@jbaudoux @simahawk any insight about this?
My thoughts are that shopfloor is meant implement incoming/outgoing/internal flows. To me it makes sense that this is a core feature. on the other hand, that would be another dependency. Thanks!
I don't think is a core feature, but I don't know if this is should be restricted to reception only. My take: if we are unsure today, let's keep it like this and then we'll see. @jbaudoux WDYT?
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-835-by-simahawk-bump-nobump, awaiting test results.
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-835-by-simahawk-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-835-by-simahawk-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 7ffc95ba64541b0a7f93fba60ad9fa2f724bddbc. Thanks a lot for contributing to OCA. ❤️