wms icon indicating copy to clipboard operation
wms copied to clipboard

[16.0][ADD] stock_release_channel_shipment_advice_deliver

Open jbaudoux opened this issue 1 year ago • 10 comments

This module adds an action to the release channel to automate the delivery of its shippings through shipment advices.

Depends on:

  • https://github.com/OCA/stock-logistics-transport/pull/114

@sbejaoui I refactored a bit the code to drop the dependency on:

  • stock_picking_started : stock_available_to_promise_release already does the check on printed
  • on propagate release channel : picking_chain_ids is more accurate https://github.com/OCA/wms/blob/16.0/stock_release_channel/models/stock_release_channel.py#L125
  • process end date: I could not figure out why this was a dependency
  • stock_picking_backorder_reason needs to be updated in the button_validate

cc @sebalix @simahawk @lmignon

jbaudoux avatar Jan 21 '24 12:01 jbaudoux

TODO: rebuild fr translation

jbaudoux avatar Jan 21 '24 12:01 jbaudoux

TODO: rebuild fr translation

done

jbaudoux avatar Jan 23 '24 16:01 jbaudoux

Added support for partial picking without backorder. The aciton_deliver doesn't raise an error anymore that it cannot be unreleased. See 948637a525db6afd193ee365e40ba4fc13a5a16c

jbaudoux avatar Apr 09 '24 10:04 jbaudoux

@sebalix @sbejaoui @lmignon @rousseldenis Can you update / put review on this one ?

jbaudoux avatar Apr 09 '24 13:04 jbaudoux

Planned upcoming improvements:

  • Add the action "Deliver" (already existing on the form view) on the kanban view (in the 3 dots)
  • If "Auto Deliver", hide "Plan Shipment" action
  • If we create manually a Shipment Advice from a release channel, when we start it, we have to set in 'delivering' state its release channel

hi @jbaudoux here is the PR for these improvements, please take a look

tuantrantg avatar Apr 11 '24 05:04 tuantrantg

@sbejaoui Can you update your review on this one?

jbaudoux avatar May 27 '24 07:05 jbaudoux

Hello @sbejaoui, gentle reminder, can you update the review please :)

cyrilmanuel avatar Jun 27 '24 07:06 cyrilmanuel

/ocabot merge nobump

jbaudoux avatar Jul 09 '24 12:07 jbaudoux

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-819-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot avatar Jul 09 '24 12:07 OCA-git-bot

@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-819-by-jbaudoux-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Jul 09 '24 12:07 OCA-git-bot

/ocabot merge nobump

rousseldenis avatar Aug 23 '24 11:08 rousseldenis

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-819-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot avatar Aug 23 '24 11:08 OCA-git-bot

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-819-by-rousseldenis-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Aug 23 '24 12:08 OCA-git-bot

@jbaudoux Could you rebase?

rousseldenis avatar Aug 23 '24 12:08 rousseldenis