wms icon indicating copy to clipboard operation
wms copied to clipboard

[14.0] shopfloor: checkout scan change lot (rebased)

Open sebalix opened this issue 1 year ago • 7 comments

Same PR than https://github.com/OCA/wms/pull/569/ but rebased on top of 14.0 to resolve conflicts (we still need the previous PR to not bring regressions as it is used as pending-merge).

Comments from @jbaudoux have been addressed too.

cc @simahawk

sebalix avatar Aug 07 '23 15:08 sebalix

Hi @simahawk, @guewen, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Aug 07 '23 15:08 OCA-git-bot

@sebalix are you going to address JE's comments too?

simahawk avatar Aug 07 '23 16:08 simahawk

@simahawk @jbaudoux comments addressed, excepting the check on the length of pickings in _select_document_from_package as it was breaking tests, indeed the relevant response is generated by _select_picking afterwards, I preferred to not change too much things for now and risk to break something else.

sebalix avatar Aug 08 '23 09:08 sebalix

@TDu @jbaudoux @sebalix what's left to be done here beside rebasing n squashing?

simahawk avatar Dec 01 '23 09:12 simahawk

@TDu @jbaudoux @sebalix what's left to be done here beside rebasing n squashing?

For me nothing but it is closely related to #785 and will need to be fixed on relation

TDu avatar Dec 01 '23 09:12 TDu

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Mar 31 '24 12:03 github-actions[bot]

@TDu @sebalix Can this be rebased & squashed ? I understand there was nothing left to be done

jbaudoux avatar May 06 '24 14:05 jbaudoux

@jbaudoux

TDu avatar Jun 03 '24 09:06 TDu

/ocabot merge minor

jbaudoux avatar Jun 03 '24 10:06 jbaudoux

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-712-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot avatar Jun 03 '24 10:06 OCA-git-bot

Congratulations, your PR was merged at 3ce2213865f9c29a4363f2d6b8a62b22a08e030c. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 03 '24 10:06 OCA-git-bot