wms icon indicating copy to clipboard operation
wms copied to clipboard

[16.0][FIX] stock_release_channel_shipment_advice_deliver job function process_shipments

Open santostelmo opened this issue 1 month ago • 2 comments

Missing job_function to _action_deliver

Actually there is a job function to _action_deliver but this one is never used as the method that is called with delay is _action_deliver.

https://github.com/OCA/wms/blob/da5e224621c6f128e84031f77f3a910673022f87/stock_release_channel_shipment_advice_deliver/models/stock_release_channel.py#L201

santostelmo avatar Nov 19 '25 09:11 santostelmo

@santostelmo Are you sure of your change?

The function exists :

https://github.com/OCA/wms/blob/da5e224621c6f128e84031f77f3a910673022f87/stock_release_channel_shipment_advice_deliver/models/stock_release_channel.py#L199

rousseldenis avatar Nov 19 '25 10:11 rousseldenis

@santostelmo Are you sure of your change?

The function exists :

https://github.com/OCA/wms/blob/da5e224621c6f128e84031f77f3a910673022f87/stock_release_channel_shipment_advice_deliver/models/stock_release_channel.py#L199

Indeed this function exists but it is never called with delay. However process_shipments does not have any linked job function and ends up being executed in the root channel

santostelmo avatar Nov 19 '25 11:11 santostelmo

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Nov 24 '25 09:11 OCA-git-bot

/ocabot merge patch

jbaudoux avatar Nov 24 '25 09:11 jbaudoux

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1113-by-jbaudoux-bump-patch, awaiting test results.

OCA-git-bot avatar Nov 24 '25 09:11 OCA-git-bot

Congratulations, your PR was merged at 3558334c8529f4c425333b2673c9f04c2e76a6f2. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Nov 24 '25 10:11 OCA-git-bot