web icon indicating copy to clipboard operation
web copied to clipboard

[18.0][MIG] web_session_auto_close

Open sbejaoui opened this issue 9 months ago • 4 comments

This module automatically closes inactive user sessions based on a configurable timeout. If no activity is detected within the set duration, the session is destroyed, and the page reloads.

sbejaoui avatar Feb 21 '25 08:02 sbejaoui

The mechanism doesn't work if the last tab is closed. You can go back in Odoo after the timeout.

glitchov avatar Feb 21 '25 09:02 glitchov

The mechanism doesn't work if the last tab is closed. You can go back in Odoo after the timeout.

please try now

sbejaoui avatar Feb 21 '25 11:02 sbejaoui

LGTM

pierre-halleux avatar Feb 21 '25 13:02 pierre-halleux

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Feb 26 '25 09:02 OCA-git-bot

Hi @sbejaoui , could you please squash all technical commits? image

It's not applicable. This commit comes from the bot there are no others commit from the bot.Blocking PRs with this type of argument will further reduce the number of contributors by adding constraints with no real added value to the work to be done.

lmignon avatar Jun 06 '25 09:06 lmignon

/ocabot migration web_session_auto_close

rousseldenis avatar Jun 06 '25 09:06 rousseldenis

It's not applicable. This commit comes from the bot there are no others commit from the bot.Blocking PRs with this type of argument will further reduce the number of contributors by adding constraints with no real added value to the work to be done.

@lmignon This is what is written in the Migration guidelines image

I don't understand how squashing commits will reduce the number of contributors.

ivs-cetmix avatar Jun 06 '25 09:06 ivs-cetmix

I don't understand how squashing commits will reduce the number of contributors.

@ivs-cetmix I think @lmignon wanted to say (as I said also), requiring more work (that has no value added - really) will discourage contributors. Moreover if they don't feel at ease with squashing, that is quite an advanced operation for newbies.

rousseldenis avatar Jun 06 '25 09:06 rousseldenis

I don't understand how squashing commits will reduce the number of contributors.

@ivs-cetmix I think @lmignon wanted to say (as I said also), requiring more work (that has no value added - really) will discourage contributors. Moreover if they don't feel at ease with squashing, that is quite an advanced operation for newbies.

@rousseldenis Sure! Let's remove pre-commit too, because it restraints so many great Odoo developers from contribution! And tests, does anyone really need them? Odoo App Store has no tests at all and look how many great apps are there!

ivs-cetmix avatar Jun 06 '25 09:06 ivs-cetmix

@rousseldenis Sure! Let's remove pre-commit too, because it restraints so many great Odoo developers from contribution! And tests, does anyone really need them? Odoo App Store has no tests at all and look how many great apps are there!

You take a wrong path... but thanks for approval.

rousseldenis avatar Jun 06 '25 09:06 rousseldenis

You take a wrong path... but thanks for approval.

I don't consider following the official documentation being a wrong path. Anyway @sbejaoui thank you for your contribution and please spend a couple of minutes more next time on reading the migration wiki. /ocabot merge nobump

ivs-cetmix avatar Jun 06 '25 09:06 ivs-cetmix

What a great day to merge this nice PR. Let's do it! Prepared branch 18.0-ocabot-merge-pr-3101-by-ivs-cetmix-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 06 '25 09:06 OCA-git-bot

Congratulations, your PR was merged at e27793b8b125dccc09c9b173cafd0398bb242ef6. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 06 '25 09:06 OCA-git-bot