web icon indicating copy to clipboard operation
web copied to clipboard

[14.0][FIX] web_edit_user_filter: Modified search facet for field type

Open anusriNPS opened this issue 1 year ago • 3 comments

To display user defined filter type in edit filter,including user defined filter values in description field of search facet element

anusriNPS avatar Jun 18 '24 08:06 anusriNPS

Congratulations for your first PR!

Just a small fix regarding the PR structure: adapt the PR name to [VERSION][TYPE] module_name: short description Other than that nice job. Let's wait for someone else to take a look at your changes

PicchiSeba avatar Jun 18 '24 09:06 PicchiSeba

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 25 '24 14:06 OCA-git-bot

@OCA/web-maintainers could this be merged? thanks

aleuffre avatar Jul 05 '24 10:07 aleuffre

@anusriNPS could you please rebase and push again to trigger a runboat build?

simahawk avatar Oct 21 '24 14:10 simahawk

@simahawk , rebased and verified changes with runboat instance

anusriNPS avatar Oct 21 '24 14:10 anusriNPS

@anusriNPS thanks. One last nit-picking thing... sorry, I didn't notice before: can you please remove the odoo version from the commit. See guidelines https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message :wink:

Other than this, we are good to go!

simahawk avatar Oct 24 '24 09:10 simahawk

@simahawk , Updated commit message as per guidelines, please let me know if its fine

anusriNPS avatar Oct 24 '24 09:10 anusriNPS

Thanks! /ocabot merge patch

simahawk avatar Oct 24 '24 10:10 simahawk

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-2854-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot avatar Oct 24 '24 10:10 OCA-git-bot

Congratulations, your PR was merged at 902d3f8b8624efe489dd3c8c0333a06ec6b72a57. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 24 '24 11:10 OCA-git-bot