web
web copied to clipboard
OCA
[17.0][MIG] web_chatter_position: Migration to 17.0
hey @legalsylvain @chienandalu @CRogos i have closed the previous PR (#2826) and created this new one following every guideline , can you please review?
This does not work at all for me. It breaks My Preferences dialog completely and I have a feeling it breaks other dialogs as well. Teste on fresh clean 17.0 It is compileForm(el, params) function breaking it...
@Rad0van Oh ! its because of the optional chaining (https://github.com/OCA/web/pull/2833/commits/12b405bc65130ff15204bfb73c0f194f05182e27) if (child.attributes?.name?.value !== "button_box") { append(form, this.compileNode(child, params)); } I have fixed this and code is working as expected but , the optional chaining is not accepted by pre-commit !! as soon as i update this, it fails , what should i do to fix that ?
@Jp-alitec PR https://github.com/OCA/web/pull/2795#issue-2242298187 Does this have any effect on PR?
@Jp-alitec In the Invoice view form, I see duplicate chatter, can you fix it? It could be even better. Thank you!
Hi, I tried this module for myself because one my client needs it. It works really well on my end, with no bug. You only have the pre-commit formatting left to do. What is the stage of progress of this PR?
@Jp-alitec I see duplicate chatter, can you fix it?
confirmed
Hi @ryantran-novobi, I am working on fixing the duplicate issue and want to include your suggestion. As I tried, I saw no effect on the form view. Could you please elaborate (nicer with images)?
@Jp-alitec I see duplicate chatter, can you fix it?
confirmed
Hi @ryantran-novobi, I am working on fixing the duplicate issue and want to include your suggestion. As I tried, I saw no effect on the form view. Could you please elaborate (nicer with images)?
Hello everyone, I fixed the issue and prepared this https://github.com/OCA/web/pull/2893
Please help to review
mhm, oficially OCA module hasn't been migrated, but based on OCA module someone has already published their own version, that seems to work in 17.0 (tho not a single word regarding the usage of OCA module, tho code is 1:1 besides minor changes to form compiler).
