web icon indicating copy to clipboard operation
web copied to clipboard

[14.0][FIX] web_notify_channel_message

Open DavidJForgeFlow opened this issue 2 years ago • 9 comments

If other user than the admin is trying to send a message to a channel it will show an error message. Sending it as sudo solves the problem and makes sense that in this case you will always want to send the notification.

@ForgeFlow

DavidJForgeFlow avatar Nov 17 '23 11:11 DavidJForgeFlow

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Dec 07 '23 11:12 OCA-git-bot

@OCA/web-maintainers Can this be merged? :pray:

bosd avatar Feb 05 '24 10:02 bosd

/ocabot merge minor

dreispt avatar Mar 09 '24 15:03 dreispt

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-2674-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot avatar Mar 09 '24 15:03 OCA-git-bot

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2674-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Mar 09 '24 15:03 OCA-git-bot

Why are tests failling during the merge? Can someone attend to this?

bosd avatar Mar 13 '24 11:03 bosd

/ocabot merge minor

dreispt avatar Apr 15 '24 11:04 dreispt

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-2674-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot avatar Apr 15 '24 11:04 OCA-git-bot

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2674-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Apr 15 '24 11:04 OCA-git-bot