web icon indicating copy to clipboard operation
web copied to clipboard

[14.0] [IMP] ckeditor: Make todoList available

Open lieblinger opened this issue 3 years ago • 9 comments

This PR adds a converter for TodoList.

The default schema for TodoLists from CKEditor is not supported by Odoo, cause elements get stripped away.

My PR adds functions to convert the TODOList schema back and forwards (Odoo <-> CKEditor). By default this PR saves Odoo's schema to the database and converts it back to the CKEditor schema for the frontend. This allows to keep TODOList working, even if someone switches back to Odoo's default editor.

What is not working: With Odoo's editor it was possible to check boxes in ReadOnlyView. This is not implemented by me and also not really needed in my case.

lieblinger avatar Oct 31 '22 16:10 lieblinger

Hi @ivantodorovich, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Oct 31 '22 16:10 OCA-git-bot

Hello, thanks a lot for this!

I tested it and it works 🎉

I would rather keep the same Odoo core style, if possible. The scss you added don't really look like the "standard" to-do list, do you think that's possible?:

image

Also, please check pre-commit, as it's failing. (for more information)

ivantodorovich avatar Oct 31 '22 17:10 ivantodorovich

Hello @lieblinger

I see you're struggling with pre-commit.

I recommend you to install it locally, as it will fix most of the "issues" automatically for you, and at the very least save you lots of time by running the checks in your terminal.

You can install it following the official docs: https://pre-commit.com/#install Then, with a shell on your git clone, run pre-commit install. That will install the pre-commit hooks into your local clone. The hooks will run before every new commit, but since you have already unstyled commits, you might need to run pre-commit run -a to scan the whole repo

ivantodorovich avatar Nov 21 '22 11:11 ivantodorovich

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Mar 09 '24 21:03 OCA-git-bot

/ocabot merge patch

dreispt avatar Apr 15 '24 11:04 dreispt

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-2330-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot avatar Apr 15 '24 11:04 OCA-git-bot

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2330-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Apr 15 '24 11:04 OCA-git-bot

@lieblinger Can you squash the last 3 commits?

bosd avatar Apr 25 '24 06:04 bosd

@lieblinger Plase squash your commits

dreispt avatar May 18 '24 16:05 dreispt