web icon indicating copy to clipboard operation
web copied to clipboard
verified publisher icon OCA

[ADD] web_widget_text_count

Open i-vyshnevska opened this issue 6 years ago • 13 comments

Field TextCount, combined to widget text_count, is displayed as a usual text field with a character counter next to it.

Screenshot

Revoked on https://github.com/OCA/web/pull/1214

i-vyshnevska avatar Aug 25 '19 23:08 i-vyshnevska

The module should be now called web_widget_text_count

pedrobaeza avatar Aug 26 '19 07:08 pedrobaeza

@simahawk @daramousk do you have time to update your reviews on this topic? Honestly we are out of time to address them. The widget is currently working well since 2019. My current proposition would be to merge this in order to let also other people use it.

leemannd avatar Oct 19 '20 14:10 leemannd

@i-vyshnevska What is the status of this pr? Can you resolve the changes? Or are they resolved?

(Would like forward port this one to V14 if this one has been approved)

bosd avatar May 19 '22 15:05 bosd

@simahawk Can you review/update changes?

bosd avatar Jul 16 '22 18:07 bosd

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 23 '23 12:07 github-actions[bot]

@bosd did you forward port this? As @leemannd stated we can merge this in the current state and give improvement later.

The main issue I see with this model is the <input> that force the user to tab into it on output and should be fixed, otherwise it works.

yvaucher avatar Feb 08 '24 16:02 yvaucher

Reopennning to merge, fixup will follow.

yvaucher avatar Feb 08 '24 16:02 yvaucher

/ocabot merge nobump

yvaucher avatar Feb 08 '24 16:02 yvaucher

This PR looks fantastic, let's merge it! Prepared branch 12.0-ocabot-merge-pr-1357-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot avatar Feb 08 '24 16:02 OCA-git-bot

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1357-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Feb 08 '24 16:02 OCA-git-bot

did you forward port this?

No, not yet. Thanks for coming back to this one.

bosd avatar Feb 09 '24 06:02 bosd

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 16 '24 12:06 github-actions[bot]

@yvaucher If you:

  • rebase the PR on 12.0
  • launch locally the pre-commit It will be fixed.

I have a PR to show it: https://github.com/OCA/web/pull/2858

leemannd avatar Jun 18 '24 15:06 leemannd