vertical-association icon indicating copy to clipboard operation
vertical-association copied to clipboard

[16.0][IMP] membership_variable_period: enable membership renewal

Open flaenen opened this issue 9 months ago • 8 comments

A member's membership is now renewed when a new variable period membership product of the same category is purchased. The new period will begin the day after the end of the last period.

flaenen avatar Mar 27 '25 15:03 flaenen

functional tests

Backend and logic

  • [x] The "buy membership" button takes current and future membership lines into account when renewing variable memberships
  • [x] If a past membership line has expired, renewal starts from today
  • [x] Postponed renewal only applies to memberships from the same category
  • [x] Postponed renewal only applies to membership states that grant effective membership ('paid', 'free' and 'invoiced')

POS UI [waiting for deployment before testing]

  • [x] Postponed renewal applies when a membership is sold in the POS to an effective member
  • [x] Compatibility with pos_membership_extension: test of both modules together

polchampion avatar Mar 28 '25 14:03 polchampion

@OCA/vertical-association-maintainers Can you take a look at this PR?

polchampion avatar Apr 03 '25 13:04 polchampion

@pedrobaeza Hi Pedro, could you take a look at this? Our PR is awaiting approval :-)

polchampion avatar Apr 17 '25 08:04 polchampion

/ocabot migration membership_variable_period

Hi, a PSC should review this PR to get it merged. https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

I'm not able to review right now, sorry.

pedrobaeza avatar Apr 17 '25 09:04 pedrobaeza

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 28 '25 08:06 OCA-git-bot

This is not a migration but a improvement / enhancement

What do you think about this @fcvalgar @Andrii9090 @chienandalu ?

rafaelbn avatar Aug 19 '25 18:08 rafaelbn

Thanks @flaenen

I'm not sure I quite understand the context or use case for this changes. Can you elaborate it a little bit?

In our use case, a customer can become a member for one year by purchasing a membership product (usually via POS). Membership begins on the date of purchase and can be renewed before expiration by purchasing the product again. Renewal must begin the day after the end of the current period (not the day of purchase) to avoid overlapping periods, ensuring that the customer receives a full additional year of membership.

flaenen avatar Aug 25 '25 14:08 flaenen

Thanks @flaenen I'm not sure I quite understand the context or use case for this changes. Can you elaborate it a little bit?

In our use case, a customer can become a member for one year by purchasing a membership product (usually via POS). Membership begins on the date of purchase and can be renewed before expiration by purchasing the product again. Renewal must begin the day after the end of the current period (not the day of purchase) to avoid overlapping periods, ensuring that the customer receives a full additional year of membership.

@OCA/vertical-association-maintainers do think this can now be merged? thanks a lot for taking a final look :-)

polchampion avatar Oct 28 '25 13:10 polchampion