OCA
[15.0][FIX] membership_extension: Don't return early
Follow-up of #159 after not getting answer
Don't return before consuming whole recordset.
@Tecnativa
This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch, awaiting test results.
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@rafaelbn The rebase process failed, because command git push --force Tecnativa tmp-pr-163:15.0-fix-membership_extension-compute_state failed with output:
remote: Permission to Tecnativa/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/Tecnativa/vertical-association/': The requested URL returned error: 403
Tests failing is due to other module (and main branch is also red). It's in my backlog to fix the branch, but not able to do it for now.
I was about to create a PR for the exact fix on 16.0
Could we get this merged and forward-ported?
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-163-by-pedrobaeza-bump-patch, awaiting test results.
Congratulations, your PR was merged at 0f73d509d3886612c2a01db6684d3f9d4e07d90c. Thanks a lot for contributing to OCA. ❤️