timesheet icon indicating copy to clipboard operation
timesheet copied to clipboard

[17.0][MIG] hr_timesheet_sheet_autodraft: Migration to 17.0

Open innovara opened this issue 8 months ago • 2 comments

hr_timesheet_sheet_autodraft/views/res_config_settings.xml requires some non-trivial changes. Derived from that there is a change in hr_timesheet_sheet/views/res_config_settings_views.xml to be able to hook up the setting to the block created by hr_timesheet_sheet.

The models work as they are.

innovara avatar Apr 03 '25 20:04 innovara

@miquelalzanillas @lbarry-apsl @BernatObrador @peluko00 @javierobcn @ppyczko @mpascuall

Would you kindly review this PR for me please? Apologies for the direct approach. Through observation I've come to the conclusion that reviews are mostly coming from direct mentions so I decided to take my chance and ask directly.

innovara avatar Apr 08 '25 15:04 innovara

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Apr 09 '25 09:04 OCA-git-bot

I have squashed the commits that were seemingly committed by CI. Difficult to tell to be honest. The module goes back 6 major versions and has been migrated 5 times previously. Surely this policy should have been enforced before 16.0 to 17.0???

innovara avatar May 11 '25 10:05 innovara

I have squashed the commits that were seemingly committed by CI. Difficult to tell to be honest. The module goes back 6 major versions and has been migrated 5 times previously. Surely this policy should have been enforced before 16.0 to 17.0???

@innovara absolutely! However looks like previous time no-one paid attention to it.

ivs-cetmix avatar May 11 '25 19:05 ivs-cetmix

/ocabot merge nobump

ivs-cetmix avatar May 11 '25 19:05 ivs-cetmix

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-760-by-ivs-cetmix-bump-nobump, awaiting test results.

OCA-git-bot avatar May 11 '25 19:05 OCA-git-bot

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 11 '25 19:05 OCA-git-bot

Congratulations, your PR was merged at 055f8af1e8a9d649a9064fe4a399fef926911f43. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 11 '25 19:05 OCA-git-bot