OCA
[IMP] hr_employee_cost_history: add comment field in history line
This PR adds a comment field on the history line to tell why the cost change did happen.
closes #696
A very small fix has been added for hr_timesheet_name_customer because Odoo has added a new test in sale_timesheet (test_billing_project/test_take_into_account_invoicing_app_legacy) which failed without doing a secure get in vals dict.
Hi @edlopen, @rafaelbn, some modules you are maintaining are being modified, check this out!
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-735-by-rafaelbn-bump-minor, awaiting test results.
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-735-by-rafaelbn-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@rafaelbn Hi Rafael, i had a look but i can't reproduce and it has nothing to do with my changes sorry.
The error is in hr_timesheet_name_customer, probably due to a change in Odoo.
Sorry @rafaelbn you are not allowed to merge.
To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.
If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.
@glitchov I removed your fix for hr_timesheet_name_customer from here and made a more complete fix in https://github.com/OCA/timesheet/pull/744
Hi @glitchov thank you for your contribution! Please rebase your branch to ensure that all the tests pass.
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-735-by-dreispt-bump-minor, awaiting test results.
It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-735-by-dreispt-bump-minor, awaiting test results.
Congratulations, your PR was merged at f1b9b08f0d54fa35e25d829527fa236286301804. Thanks a lot for contributing to OCA. ❤️