stock-logistics-workflow icon indicating copy to clipboard operation
stock-logistics-workflow copied to clipboard
verified publisher icon OCA

[15.0][FIX] stock_valuation_fifo_lot: fix _get_price_unit() function and mrp dependence

Open Tisho99 opened this issue 3 months ago • 4 comments

This PR fixes some errors of the module:

  • In the price unit calculation, use the default value if the move is a return. Odoo has an special case for that to calculate it correctly (with this module installed, the result in that case is wrong)
  • In the price unit calculation, take into account the related landed costs of the candidate SVL
  • Add a new module, stock_valuation_fifo_lot_mrp_landed_cost, to cover the needed mrp_landed_costs dependency. The mrp_production_ids field, used in this module, is created in the mrp_landed_costs module

Unit tests have also been added to cover the case of returning a outgoing shipping

The README has also been improved

T-8760

Tisho99 avatar Sep 16 '25 12:09 Tisho99

Hi @newtratip, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Sep 16 '25 12:09 OCA-git-bot

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Oct 15 '25 06:10 OCA-git-bot

Hello @newtratip

This PR includes some fixes for the module you created. It’s ready to merge. Would you be interested in reviewing it?

Thanks!

Tisho99 avatar Oct 15 '25 08:10 Tisho99

Hello @dreispt

This PR includes a few fixes for the module you previously merged. Would you be interested in reviewing it?

Thanks!

Tisho99 avatar Oct 20 '25 07:10 Tisho99