stock-logistics-warehouse icon indicating copy to clipboard operation
stock-logistics-warehouse copied to clipboard

[17.0][MIG] stock_helper

Open CarlosVForgeFlow opened this issue 2 years ago • 2 comments

Migration to 17.0

@ForgeFlow

CarlosVForgeFlow avatar Mar 15 '24 15:03 CarlosVForgeFlow

@LoisRForgeFlow @jbaudoux An improvement I requested was to refactor the module name in order to avoid putting a lot of things inside it without context.

stock_location_sublocation_of / stock_location_from_route /... is better

or at least stock_helper_location_sublocation / stock_helper_location_from_route if we want to keep the 'helper' term

rousseldenis avatar Mar 18 '24 10:03 rousseldenis

@LoisRForgeFlow @jbaudoux An improvement I requested was to refactor the module name in order to avoid putting a lot of things inside it without context.

stock_location_sublocation_of / stock_location_from_route /... is better

or at least stock_helper_location_sublocation / stock_helper_location_from_route if we want to keep the 'helper' term

Right now it is only 2 helpers and none of them makes or generates any problem if not used. I don't know if such atomization would provide real value in this case.

My 2 cents

LoisRForgeFlow avatar Mar 18 '24 14:03 LoisRForgeFlow

/ocabot merge nobump

LoisRForgeFlow avatar Jun 13 '24 10:06 LoisRForgeFlow

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1959-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 13 '24 10:06 OCA-git-bot

Congratulations, your PR was merged at 8f179ba58e74fc2e8124b23c851ad67ac4035845. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 13 '24 10:06 OCA-git-bot