social icon indicating copy to clipboard operation
social copied to clipboard
verified publisher icon OCA

[16.0][MIG] mig mail_restrict_send_button

Open NL66278 opened this issue 8 months ago • 4 comments

Resubmitting PR https://github.com/OCA/social/pull/1112 after rebasing and resolving conflicts.

Tested succesfully.

NL66278 avatar Apr 11 '25 11:04 NL66278

Once you have finished all the changes don't forget to squash the commits into the migration one.

AlvaroRM11 avatar Apr 14 '25 08:04 AlvaroRM11

@AlvaroRM11 I cannot really squash them as the original migration was not done by me. So two after-migration commits only have my name, but they improve two quite distinct aspects of the code.

NL66278 avatar Apr 14 '25 10:04 NL66278

Got it, just ignore me and carry on.

AlvaroRM11 avatar Apr 14 '25 10:04 AlvaroRM11

@AlvaroRM11 I looked again at the commit history as due to resolving conflicts and rebases some things got mixed up and I finally succeeded in getting a more or less clean history again. Would you like to do a review?

NL66278 avatar Apr 14 '25 11:04 NL66278

/ocabot merge nobump

hbrunn avatar May 23 '25 07:05 hbrunn

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-1632-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot avatar May 23 '25 07:05 OCA-git-bot

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 23 '25 07:05 OCA-git-bot

Congratulations, your PR was merged at 21ecaf18f2242db442fc8e88a43848684ef28483. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 23 '25 07:05 OCA-git-bot