OCA
[17.0][IMP] mail_send_confirmation: wizard
Add confirmation to the wizard as well since even though the emails are shown in both cases, a confirmation reduces wrongfully sent messages
@yostashiro thanks for the review! As for your question - for quick composer it has to be done via JS as it's a custom component, see https://github.com/odoo/odoo/blob/9af66f9ef02c7412aac5c31eb9ca631b8cf57332/addons/mail/static/src/core/common/composer.js
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1544-by-hbrunn-bump-patch, awaiting test results.
@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1544-by-hbrunn-bump-patch.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-1544-by-hbrunn-bump-patch, awaiting test results.
@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1544-by-hbrunn-bump-patch.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@alexey-pelykh this seems to break the tests of mail_forward. as I don't see an easy way to make this work, please declare mail_send_confirmation a rebel module
@hbrunn thanks for alerting me, wasn't the case at the time - I'll proceed as suggested
hmm, doesn't seem to be caused by your code after all. will look into fixing mail_forward then
ah, correction: You didn't actually make it a rebel module, see https://github.com/OCA/social/pull/1667 - please cherry pick that, then this should be good to go
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1544-by-hbrunn-bump-patch, awaiting test results.
Congratulations, your PR was merged at 02a469a3080f52c838b1fd79b3535588306e143f. Thanks a lot for contributing to OCA. ❤️