social icon indicating copy to clipboard operation
social copied to clipboard

[17.0][MIG] mail_show_follower: Migration to 17.0

Open ericchew87 opened this issue 1 year ago • 1 comments

My company just started using Odoo in July of 2024. This is my attempt to port this OCA module which we want to utilize in version 17.0. One place I think needs work is the translations. I changed some text to be more concise but then realized afterwards it would mess up the translations doing this. I appreciate any tips on whether its worth making this change, or if I should revert the text to what was in 16.0.

Thank you! Eric

ericchew87 avatar Sep 11 '24 19:09 ericchew87

Files impacting translations have been reverted, this is ready for review.

ericchew87 avatar Sep 12 '24 13:09 ericchew87

Any updates on this?

Bart-dh avatar Nov 20 '24 13:11 Bart-dh

I have been using this on my Odoo site in production without issues. If anything else is required on my end to get it approved, please let me know.

ericchew87 avatar Nov 20 '24 13:11 ericchew87

@chusamo ?

Bart-dh avatar Nov 20 '24 13:11 Bart-dh

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jan 20 '25 13:01 OCA-git-bot

Can you squash your migration commits in a single one?

etobella avatar Jan 20 '25 14:01 etobella

@etobella Maybe I should make a supersede? Since the user isn't responding and doesn't seem very active

ArnauCForgeFlow avatar Jan 27 '25 12:01 ArnauCForgeFlow

Sure!

etobella avatar Jan 27 '25 12:01 etobella

Apologies...I'm here. I've been caught up with year-end tasks at my company. I can try to knock this out if it isn't too late.

ericchew87 avatar Jan 27 '25 12:01 ericchew87

@ericchew87 Sure! I hadn’t started working on the supersede, so feel free to complete it yourself.

ArnauCForgeFlow avatar Jan 27 '25 13:01 ArnauCForgeFlow

Were those the ones you needed squashed? Please let me know if you need me to do anything else. Thank you.

ericchew87 avatar Jan 27 '25 13:01 ericchew87

Hey @ericchew87 , I think you should have kept the pre-commit auto fixes commit, also in the migration commit is missing the module name. In the following link you can find more information if you search in the 'how-to' section.

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

ArnauCForgeFlow avatar Jan 28 '25 14:01 ArnauCForgeFlow

Thank you both for your input. I'm not sure how quickly I will be able to get to this, but will try to make some time. If you prefer to get it done on your end to push it along, that works for me as well.

ericchew87 avatar Jan 30 '25 18:01 ericchew87

Superseded by #1570

pedrobaeza avatar Feb 12 '25 16:02 pedrobaeza