social icon indicating copy to clipboard operation
social copied to clipboard

[17.0][MIG] mass_mailing_list_dynamic

Open pedro-gonzalez-aulora opened this issue 1 year ago • 5 comments

Work done:

  • [x] Code compatible with v17
  • [x] Tests compatible with v17
  • [x] Avoid ruff complain on pre-commit image

pedro-gonzalez-aulora avatar May 15 '24 06:05 pedro-gonzalez-aulora

@pedro-evaristo-pegon is this version functional, or still problems?

Bart-dh avatar Aug 02 '24 07:08 Bart-dh

@pedro-evaristo-pegon is this version functional, or still problems?

Hi @Bart-dh , I did my own functional tests in local and all worked. You can also fork my PR and have a look at it.

@pedrobaeza do I need to do anything else to generate the build of the PR?

pedro-gonzalez-aulora avatar Aug 06 '24 14:08 pedro-gonzalez-aulora

Rebase + force push to get a fresh new build.

pedrobaeza avatar Aug 06 '24 14:08 pedrobaeza

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Sep 12 '24 11:09 OCA-git-bot

@OCA/social-maintainers Is it possible to take a look at this PR?

FernandoRomera avatar Sep 16 '24 10:09 FernandoRomera

@OCA/social-maintainers Can anyone please check the current status of this PR?

AArana670 avatar Feb 04 '25 09:02 AArana670

@AArana670 until the requested changes are fixed it won't be merged.

giarve avatar Feb 09 '25 11:02 giarve

@pedro-evaristo-pegon can you attend the remaining comments?

pedrobaeza avatar Feb 13 '25 20:02 pedrobaeza

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Feb 17 '25 14:02 OCA-git-bot

/ocabot migration mass_mailing_list_dynamic /ocabot merge nobump

pedrobaeza avatar Feb 17 '25 15:02 pedrobaeza

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1368-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Feb 17 '25 15:02 OCA-git-bot

Congratulations, your PR was merged at a6045dd6932ca728be982a793110c43a2090c665. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Feb 17 '25 15:02 OCA-git-bot