social icon indicating copy to clipboard operation
social copied to clipboard

[MIG] mail_template_substitute: Migration to 17.0

Open SodexisTeam opened this issue 1 year ago • 7 comments

SodexisTeam avatar Feb 26 '24 05:02 SodexisTeam

/ocabot migration mail_template_substitute

hbrunn avatar Mar 25 '24 07:03 hbrunn

Note that this module doesn't work for account.move.send anymore, because account.move.send doesn't inherit from {'mail.compose.message':'composer_id'} anymore. Maybe this issue could be found at other places too.

ahaly-compass avatar Apr 12 '24 05:04 ahaly-compass

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 08 '24 08:05 OCA-git-bot

I'm not so sure if we should add a dependency on account to this module, or add support for account in another module. What do reviewers think?

I think it would be good to have a separate module(mail_template_substitute_account_move) as it would avoid adding "account" as dependency. Thus, we create new module with auto_install=True and depends contains mail_template_substitue and account. Should we add this new module in this repository or other OCA/account related repository?

atchuthan avatar May 13 '24 06:05 atchuthan

mail_template_substitute_account_move in oca/account-financial-tools sounds good to me

hbrunn avatar May 13 '24 06:05 hbrunn

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 13 '24 12:05 OCA-git-bot

mail_template_substitute_account_move in oca/account-financial-tools sounds good to me

New Module created in account-financial-tools https://github.com/OCA/account-financial-tools/pull/1881 Please review

sakthi-shan avatar May 15 '24 14:05 sakthi-shan

@OCA/social-maintainers can we merge this PR?

atchuthan avatar May 21 '24 10:05 atchuthan

/ocabot merge nobump

hbrunn avatar May 27 '24 09:05 hbrunn

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1314-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot avatar May 27 '24 09:05 OCA-git-bot

Congratulations, your PR was merged at 88747d0cfb92078e1f4c6294b5efd232bf1a73d4. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 27 '24 09:05 OCA-git-bot