[MIG] mail_template_substitute: Migration to 17.0
/ocabot migration mail_template_substitute
Note that this module doesn't work for account.move.send anymore, because account.move.send doesn't inherit from {'mail.compose.message':'composer_id'} anymore. Maybe this issue could be found at other places too.
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
I'm not so sure if we should add a dependency on account to this module, or add support for account in another module. What do reviewers think?
I think it would be good to have a separate module(mail_template_substitute_account_move) as it would avoid adding "account" as dependency. Thus, we create new module with auto_install=True and depends contains mail_template_substitue and account. Should we add this new module in this repository or other OCA/account related repository?
mail_template_substitute_account_move in oca/account-financial-tools sounds good to me
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
mail_template_substitute_account_movein oca/account-financial-tools sounds good to me
New Module created in account-financial-tools https://github.com/OCA/account-financial-tools/pull/1881 Please review
@OCA/social-maintainers can we merge this PR?
/ocabot merge nobump
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1314-by-hbrunn-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 88747d0cfb92078e1f4c6294b5efd232bf1a73d4. Thanks a lot for contributing to OCA. ❤️