OCA
[15.0][BKP][FIX] mail_composer_cc_bcc: send RFQ by email
Hi @hailangvn2023, some modules you are maintaining are being modified, check this out!
This appears to work other than in one corner case that may not apply to most instances.
When a user is following tracked field changes, the cc user still gets added to that e-mail. This may not be normal/possible on most instances, but this happens to us when a user is following "All" chatter activity.
I had to update _notify_by_email_add_values to check for mail_message_id, browse for the record, and check if message type is notification to avoid adding CC and BCC from there. Not sure if this is the best approach since it will require a browse on each message, but it does resolve the noted issue.
What is the state here? I have noticed the sending for duplicate emails when using BCC for the 17.0 version of the module. I wonder if it is related or if it is actually a bug or a feature.
What is the state here? I have noticed the sending for duplicate emails when using BCC for the 17.0 version of the module. I wonder if it is related or if it is actually a bug or a feature.
Hi, I am working on the fix, will be ready soon
@hbrunn The rebase process failed, because command git rebase origin/15.0 failed with output:
Rebasing (1/1)
Auto-merging mail_composer_cc_bcc/README.rst
CONFLICT (content): Merge conflict in mail_composer_cc_bcc/README.rst
Auto-merging mail_composer_cc_bcc/static/description/index.html
CONFLICT (content): Merge conflict in mail_composer_cc_bcc/static/description/index.html
error: could not apply c0a2c8f5... [FIX] mail_composer_cc_bcc: send RFQ by email
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply c0a2c8f5... [FIX] mail_composer_cc_bcc: send RFQ by email