[16.0][MIG] mail_template_multi_attachment
cc: @SodexisTeam
@OCA/social-maintainers Could you please add this module to the list of modules?
Any info in this module, and why it is not migrated to odoo 15 / odoo 16 ? Please give me some hint.
/ocabot migration mail_template_multi_attachment
Any info in this module, and why it is not migrated to odoo 15 / odoo 16 ? Please give me some hint.
It was not in the v16 mig list because it was not in v15 when the 16.0 branch was created. Is not in v15 because nobody migrated it. Feel free to do it if you need it :wink:
I've forked the repo, and made some changes, then I've commited them. https://github.com/OCA/social/commit/9ecdc0392bef58e03827204db8eeefa55f6e85db
How can I now ask for a pull request and put it into OCA/social ?
On Wed, Aug 16, 2023 at 7:45 AM Simone Orsi @.***> wrote:
Any info in this module, and why it is not migrated to odoo 15 / odoo 16 ? Please give me some hint.
It was not in the v16 mig list because it was not in v15 when the 16.0 branch was created. Is not in v15 because nobody migrated it. Feel free to do it if you need it 😉
— Reply to this email directly, view it on GitHub https://github.com/OCA/social/pull/1094#issuecomment-1679997684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMEREFOYRPZX3W6ZR6SYV3XVRM7BANCNFSM6AAAAAAVWNPFJA . You are receiving this because you commented.Message ID: @.***>
I've forked the repo, and made some changes, then I've commited them. 9ecdc03 How can I now ask for a pull request and put it into OCA/social ?
Sorry, I don't understand your question. What are you trying to achieve? If you are trying to add a change to this PR you should open it against the fork of @atchuthan and ask him if he could integrate it here.
hi @atchuthan. Thanks for porting this module. Could you take a look on the @jdidderen-noviat remark, and ideally add tests ?
thanks !
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
hi @atchuthan . will you finish this PR ? thanks !
hi @atchuthan . will you finish this PR ? thanks !
@legalsylvain sorry for the late reply. Above changes requested are done in the latest changes. Please check and let us know.
@jdidderen-noviat : Could you update your review ?
@acsonefho : FYI.
@OCA/social-maintainers could we merge this PR?
/ocabot merge nobump
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-1094-by-simahawk-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 3c2b8e3b8112347430868045414bce008393e515. Thanks a lot for contributing to OCA. ❤️