server-ux icon indicating copy to clipboard operation
server-ux copied to clipboard

[16.0][IMP] base_tier_validation: Change _compute_need_validation()

Open BernatPForgeFlow opened this issue 1 year ago • 4 comments
trafficstars

A document does not need validation only if there are no pending reviews, otherwise we should evaluate as True. We add a condition in request_validation to be able to request more than one time if there are new tier validations.

BernatPForgeFlow avatar Jul 24 '24 08:07 BernatPForgeFlow

Hi @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jul 24 '24 08:07 OCA-git-bot

Would you consider adding a test to demonstrate what this effectively changes in the flow?

StefanRijnhart avatar Aug 26 '24 10:08 StefanRijnhart

Thanks for the update. Do I understand correctly that the commit message may be updated to say

more than one time if there are new tier definitions

rather than new tier validations?

StefanRijnhart avatar Sep 02 '24 10:09 StefanRijnhart

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Sep 02 '24 10:09 OCA-git-bot

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jan 05 '25 12:01 github-actions[bot]

/ocabot merge minor

StefanRijnhart avatar Jan 05 '25 12:01 StefanRijnhart

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-928-by-StefanRijnhart-bump-minor, awaiting test results.

OCA-git-bot avatar Jan 05 '25 12:01 OCA-git-bot

Congratulations, your PR was merged at 087e6c69a6a9b955e7440a08a451ea3b4f5a6d71. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jan 05 '25 12:01 OCA-git-bot