server-ux icon indicating copy to clipboard operation
server-ux copied to clipboard
verified publisher icon OCA

[FIX][17.0] date_range : error opening conditional on studio

Open micheledic opened this issue 1 year ago • 5 comments

Fixes issue https://github.com/OCA/server-ux/issues/909

micheledic avatar Jul 04 '24 13:07 micheledic

Hi @lmignon, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jul 04 '24 13:07 OCA-git-bot

@DavidBForgeFlow @LoisRForgeFlow ping

micheledic avatar Jul 09 '24 10:07 micheledic

@DavidBForgeFlow @LoisRForgeFlow @lmignon we need this fix in our production env

micheledic avatar Jul 15 '24 08:07 micheledic

Test ok

CLEBORGNEAPIK avatar Sep 02 '24 15:09 CLEBORGNEAPIK

Any news? The Issue Is still on production

micheledic avatar Oct 05 '24 15:10 micheledic

@pedrobaeza can you check ?

micheledic avatar Oct 08 '24 09:10 micheledic

Sorry, not using Studio, and the changes seem very wide.

pedrobaeza avatar Oct 08 '24 09:10 pedrobaeza

Sorry, not using Studio, and the changes seem very wide.

who can check this ? the bug is still there, if somebody open studio on conditional field the error pops up my PR only put a if above

micheledic avatar Oct 08 '24 09:10 micheledic

What about this smaller fix? https://github.com/OCA/server-ux/pull/949 Yet I'm not sure it's complete.

simahawk avatar Oct 11 '24 06:10 simahawk

I had missed the fix on the updateLeafOperator which is included here, thank you for this! I have now added it in the other PR as well:

  • https://github.com/OCA/server-ux/pull/949

The fixes are similar, here the code section is wrapped in if-clause while the above PR just returns early. Impactful line changes are the same as here it is mostly indentation.

henrybackman avatar Oct 11 '24 07:10 henrybackman

@henrybackman Can you close close this one in favor of #949 ?

lmignon avatar Oct 11 '24 07:10 lmignon