server-ux
server-ux copied to clipboard
OCA
[16.0][FIX] base_tier_validation: Field merge in view
Previous implementation was losing fields in some cases; new one properly merges dicts/tuples.
This fixes odd "Missing field string information" errors in form-embedded lists.
This cset also removes an obsolete base_model_name context key no longer used in Odoo 16.
This cset adds a test_get_view test which checks for that need_validation field; it was failing with the previous impl.
Fixes #825.
Hi @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!
@houzefa-abba I was testing sale_tier_validation and experienced a bug where all reviews where accepted (with sequence approve enabled) but confirm action in sale order keep raising "The operation is under validation". After applied this PR to my code everything worked as expected. Any thoughts???
@houzefa-abba I was testing sale_tier_validation and experienced a bug where all reviews where accepted (with sequence approve enabled) but confirm action in sale order keep raising "The operation is under validation". After applied this PR to my code everything worked as expected. Any thoughts???
O that's good to know!
Well I haven't heavily configured / used tier validations so far so I'll take your word for it.
It doesn't surprise me though; with the previous implementation, some fields (such as those in test_get_view) could go missing, and since Odoo's view cache system is also involved here, results were not always predictable.
Hi @houzefa-abba
Thanks for you fix, could you fix conflicts in order to be able to merge?
Hi @houzefa-abba
Thanks for you fix, could you fix conflicts in order to be able to merge?
Hi @LoisRForgeFlow thanks for reviewing, rebase is done!
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-846-by-LoisRForgeFlow-bump-patch, awaiting test results.
Congratulations, your PR was merged at a0bc678e8ba3f857b504fbc92315dfde036c900b. Thanks a lot for contributing to OCA. ❤️
@houzefa-abba it seems that https://github.com/OCA/server-ux/pull/923 got closed for some reason. If you want this fix to survive in next versions, could you forward port it to 17.0?