base_tier_validation: Missing field "need_validation" in form-embedded lists

[houzefa-abba]

trafficstars

Hi here is an issue when a model plugged to base_tier_validation is displayed as a list in another form: when clicking a record in such a list, the view crashes:

Error: Missing field string information for the field 'need_validation' from the 'res.partner' model

An easy way to test this is from a partner-contact runboat:

• open contacts, switch to list view
• select 2 contacts > Action > Merge (standard Odoo feature)
• in the merge wizard, click on a partner

➔ Screenshot:

This isn't specific to that model nor to that wizard; I can also reproduce from a sale-workflow runboat in a more convoluted way:

• create a quotation, sell a product tracked via serial number (eg "Drawer")
• open that serial number (lot) form within Inventory
• edit view to remove invisibility condition on the sale_order_ids field
• click on a sales order

➔ Screenshot:

[tugsbayarg]

You have to add need_validation field with invisiblity=1 in form view. To add field into view you need to inherit main form view and add field into inherited form view

[houzefa-abba]

You have to add need_validation field with invisiblity=1 in form view. To add field into view you need to inherit main form view and add field into inherited form view

Hi that indeed seems to be what's missing; the issue here is base_tier_validation users never added that so far (eg in sale_tier_validation).

Adding it by hand in each derived module seems cumbersome to me; especially when talking about modals such as that partner merge one which may well define their own views.

I think the assumption so far was that the mixin provided by base_tier_validation would inject these fields, same as it already injects some UI elements such as validation buttons.