OCA
[17.0][MIG] base_optional_quick_create: Migration to 17.0
In Odoo17, Odoo has removed these 2 methods, _patch_method and _revert_method. According to their description here in PR 110370. They think this is only used in test cases and needs a proper use case.
So in a new update, they have removed these methods and inside test cases, they now use patch from unittest.mock.
In this module, I guess we can not use that since it will confuse people since this patch method is coming from a unit test.
So, as a solution, I added again these 2 methods in the module itself.
@desdelinux could be pelase guide me how can I make runbot running. Because I am unable to understand why it is not running.
@desdelinux could be pelase guide me how can I make runbot running. Because I am unable to understand why it is not running.
@jaydeep32 Force your last push to try to regenerate the runbot again
Hi @lmignon. Your command failed:
Invalid command: migrate.
Ocabot commands
ocabot merge major|minor|patch|nobumpocabot rebaseocabot migration {MODULE_NAME}
More information
- ocabot documentation
- OCA guidelines, specially the "Version Numbers" section.
@lmignon
/ocabot migration base_optional_quick_create
apparently, it didn't work
cc @desdelinux
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-819-by-gurneyalex-bump-nobump, awaiting test results.
@gurneyalex The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-ux --branch 17.0 --addons-dir /tmp/tmp0iij0pru --commit failed with output:
Both .md and .rst found for DESCRIPTION. Please remove one of /tmp/tmp0iij0pru/base_optional_quick_create/readme/DESCRIPTION.rst or /tmp/tmp0iij0pru/base_optional_quick_create/readme/DESCRIPTION.md.
@jaydeep32 can you remove the readme/*.rst files? This should allow merging.
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-819-by-gurneyalex-bump-nobump, awaiting test results.
@gurneyalex The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-ux --branch 17.0 --addons-dir /tmp/tmptl_oc038 --commit failed with output:
Both .md and .rst found for DESCRIPTION. Please remove one of /tmp/tmptl_oc038/base_optional_quick_create/readme/DESCRIPTION.rst or /tmp/tmptl_oc038/base_optional_quick_create/readme/DESCRIPTION.md.
hi @jaydeep32
you have a message here, it's a small fix to set as ready to merge...
can you do it? please...
regards
Hello @gurneyalex I have removed these files. Sorry for the delay. I did not realize there was a message for me here.
On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-819-by-gurneyalex-bump-nobump, awaiting test results.
Congratulations, your PR was merged at ac7a3d1b91a4ff36abb50c77eb5fe290dbb1d028. Thanks a lot for contributing to OCA. ❤️