server-ux icon indicating copy to clipboard operation
server-ux copied to clipboard

[16.0][ADD] base_tier_validation_board

Open JasminSForgeFlow opened this issue 1 year ago • 3 comments

It will show all tier reviews under Dashboard

@ForgeFlow

JasminSForgeFlow avatar Feb 01 '24 11:02 JasminSForgeFlow

@JasminSForgeFlow I tested with purchase_tier_validation, and I can see that a user that has no permission for purchasing can list the tier reviews associated to purchase orders:

image

In mail_activity_board it used to be resolved by https://github.com/OCA/social/blob/14.0/mail_activity_board/models/mail_activity.py#L84

But I can see that this code has been removed in 15.0 onwards...

JordiBForgeFlow avatar Feb 08 '24 15:02 JordiBForgeFlow

@JasminSForgeFlow in mail_activity_board this does not happen (a user that does not have permission for purchase.order cannot see activities related) due to https://github.com/odoo/odoo/blob/16.0/addons/mail/models/mail_activity.py#L375.

Can you propose the equivalent of https://github.com/odoo/odoo/blob/16.0/addons/mail/models/mail_activity.py#L375 to the base_tier_validation module?

JordiBForgeFlow avatar Feb 08 '24 15:02 JordiBForgeFlow

@JasminSForgeFlow in mail_activity_board this does not happen (a user that does not have permission for purchase.order cannot see activities related) due to https://github.com/odoo/odoo/blob/16.0/addons/mail/models/mail_activity.py#L375.

Can you propose the equivalent of https://github.com/odoo/odoo/blob/16.0/addons/mail/models/mail_activity.py#L375 to the base_tier_validation module?

HI, it is implemented, Thanks

JasminSForgeFlow avatar Feb 13 '24 11:02 JasminSForgeFlow

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 16 '24 12:06 github-actions[bot]

/ocabot merge nobump

LoisRForgeFlow avatar Jun 25 '24 07:06 LoisRForgeFlow

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-817-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 25 '24 14:06 OCA-git-bot

Congratulations, your PR was merged at 51953f4720df73bad7a541c2d0d70503912a9864. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 25 '24 15:06 OCA-git-bot