server-ux icon indicating copy to clipboard operation
server-ux copied to clipboard

[16.0][ADD] base_tier_validation: allow comments being optional

Open hbrunn opened this issue 2 years ago • 4 comments

this allows comments to be configured to be optional depending on the record being validated/rejected (the defaults are chosen such that existing definitions won't behave differently after the update)

hbrunn avatar Aug 29 '23 06:08 hbrunn

Hi @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Aug 29 '23 06:08 OCA-git-bot

approve functional review

toyrobot avatar Aug 29 '23 16:08 toyrobot

Looks good! I know it is not by this commit. But it is a bit confusing that the field has_comment actually means can_comment

bosd avatar Jan 12 '24 06:01 bosd

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 19 '24 12:05 github-actions[bot]

Hi,

This PR has been tested and works like a charm.

Stephanvandenberg avatar Jan 16 '25 08:01 Stephanvandenberg