server-ux icon indicating copy to clipboard operation
server-ux copied to clipboard

[16.0][FIX] base_cancel_confirm: Fix missing fields in models dict

Open risto42 opened this issue 3 weeks ago • 1 comments

Fixes #1190

When base_cancel_confirm injects fields into view XML, those fields must also be added to the models dictionary returned by get_view().

The bug: Lines 72-77 skipped merging fields when the model already existed:

if model in all_models:
    continue  # Bug: skips merging!

This caused JavaScript errors:

Missing field string information for the field 'cancel_confirm' from the 'account.payment' model

The fix: Merge new fields with existing ones instead of skipping.

Impact: All models using base.cancel.confirm (account.payment, account.move, sale.order, purchase.order, etc.)

Testing: Verified with account.payment forms - no more JS errors.

risto42 avatar Nov 15 '25 18:11 risto42

Hi @kittiu, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Nov 15 '25 18:11 OCA-git-bot