server-ux icon indicating copy to clipboard operation
server-ux copied to clipboard

[FIX] base_tier_validation: comment support approve_sequence_bypass

Open mathben opened this issue 3 months ago • 3 comments

  • the comment will only be added to last review and remove repetition

Improve https://github.com/OCA/server-ux/pull/975 Fix https://github.com/OCA/server-ux/pull/802 Fix https://github.com/OCA/server-ux/pull/803 Fix https://github.com/OCA/server-ux/pull/699

This code was ignoring approve_sequence_bypass

mathben avatar Sep 24 '25 07:09 mathben

Hi @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Sep 24 '25 07:09 OCA-git-bot

Tests doesn't cover this feature, I will try to add more. Only 1 test approve_sequence_bypass : test_12_approve_sequence_same_user_bypassed

Do you think it's necessary to add an option to decide if comment is repeated for each approbation or only on the last sequence?

mathben avatar Sep 25 '25 22:09 mathben

Add feature to show note when missing notifier, this is the reason of failing test.

mathben avatar Sep 26 '25 07:09 mathben