[17.0] [FIX] base_tier_validation: Fixed readonly behavior of fields.

[NachoAlesLopez]

trafficstars

The module base_tier_validation behaves strangely when computed fields are present. For example, the following screenshots come from a base installation of Odoo with the sale_tier_validation and sale_purchase module added, which causes the purchase order count to be editable when inside a smartbutton:

Or, when paired with the sale_margin module, it allows the editing of the margin when the field should be read-only:

This is because the base module doesn't take into account the read-onliness of the fields, especially computed fields. This PR should fix that behavior and add a test case to ensure the cases shown before remain patched.

[OCA-git-bot]

Hi @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!

[NachoAlesLopez]

@LoisRForgeFlow It looks like the changes from https://github.com/OCA/server-ux/pull/1107 fixed the issue. I'll close the PR in that case. Thanks for letting me know of the fix!

[LoisRForgeFlow]

@NachoAlesLopez That's good news! thanks for checking and confirming :+1: