server-ux icon indicating copy to clipboard operation
server-ux copied to clipboard

[17.0][FIX] base_tier_validation - wrong order of reviewer when click…

Open DucTruongKomit opened this issue 10 months ago • 2 comments

Current Behavior the sequence order of review on Request Validation button be always reverted.

For example: from Tier Definition, creating On Purchase Request, User A will be set as sequence 1 (this person review 1st). On Purchase Request, User B will be set as sequence 2 (this person review 2nd).

After clicking Request Validation button, User B always be asked to reviewed 1st.

Expected Behavior Reviewing should be following the order of sequence.

DucTruongKomit avatar Mar 06 '25 08:03 DucTruongKomit

Hi @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Mar 06 '25 08:03 OCA-git-bot

Hi @DucTruongKomit

This makes sense and it is an issue that needed to be addresed. However, to be able to merge this, you will need to provide migration scripts that reverts all the sequences in existing tier definitions to not change behavior in existing installations. Could you do that?

Thanks for contributing!

I will try to arrange time and work on it.

DucTruongKomit avatar Mar 07 '25 03:03 DucTruongKomit

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 06 '25 12:07 github-actions[bot]