server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[ADD] fix_compute_trans_implied_groups

Open SirPyTech opened this issue 6 months ago • 7 comments

This fix should be in Odoo's 14.0 branch but it's no more maintained, so we have to create a module. This isn't needed in 16.0 thanks to https://github.com/odoo/odoo/commit/34d6f87d5497182d8ce395a8c90277f5ddde8a95.

I haven't added a test in this module because the only way I know to reproduce this bug is to install the sale module and it makes no sense to add such a dependency in this module.

Let me know what you think!

SirPyTech avatar Jun 26 '25 14:06 SirPyTech

@OCA/tools-maintainers wdyt?

francesco-ooops avatar Jun 30 '25 12:06 francesco-ooops

@SirPyTech For the unit test what you could do is to create a separate _test module which has the test and also depends on sale.

thomaspaulb avatar Jul 01 '25 14:07 thomaspaulb

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 01 '25 14:07 OCA-git-bot

Also, can you explain your reason for not using OCB?

thomaspaulb avatar Jul 01 '25 14:07 thomaspaulb

Thanks @thomaspaulb for having a look! I'll try to move this fix to OCB and then maybe I'll be able to add a proper test in sale module :rocket: I didn't use OCB at first because I thought our customer wasn't using it.

SirPyTech avatar Jul 01 '25 15:07 SirPyTech

Moved to https://github.com/OCA/OCB/pull/1306

SirPyTech avatar Jul 02 '25 12:07 SirPyTech

Reopening to allow non-OCB users to enjoy this fix

SirPyTech avatar Jul 09 '25 14:07 SirPyTech