OCA
[16.0] Update fetchmail_server_folder
- Update fields description for clarity
- Support fetch_last_day_only to fetch only 24 hours of emails
- Process emails in reverse order
- Use BODY.PEEK to avoid marking email as seen
- Support email field 'reply_to' to matching
- Improve logging
- Relayout view to group related fields
Hi @NL66278, some modules you are maintaining are being modified, check this out!
@ikus060 Thank you for that. However pre-commit job is still complaining. Coud you run pre-commit run --all-files --show-diff-on-failure --color=always.
And if possible squash your changes into a single commit.
@ikus060 Just some small remarks on the xml formatting and we should be good to go...
@ikus060 You might also have a look at my PR to use message uid instead of number in folder. I think the same problem you solve with handling the messages in reverse order. https://github.com/OCA/server-tools/pull/3017
Here another tentative. Sorry for all the noise. I'm not used to OCA code policies.
See my comments for #3017
@ikus060 No problem. They are here: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst
@ikus060 Nothing really blocking, but waiting for more reviews. @hbrunn Maybe you want to have a look?
Hello All,
I took some time to update this Pull Request with the changes recommended.
@zamberjo I think this is ready for merge now. Can you also have another look?
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-3222-by-NL66278-bump-minor, awaiting test results.
@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3222-by-NL66278-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-3222-by-NL66278-bump-minor, awaiting test results.
@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3222-by-NL66278-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
For some reason merge commits fails on tests that ran successfully when submitting the PR. On modules that have nothing to do with this PR.
@NL66278 that's normal behavior, tests are run on the head branch with the PR merged in. And this fails currently because of changes in Odoo, fixed in https://github.com/OCA/server-tools/pull/3271
@ikus060 next time you create a PR please give it a name that's more descriptive than "Update ..."
Conflicts can be resolved by merging this PR: https://github.com/ikus060/server-tools/pull/1