server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard
verified publisher icon OCA

[16.0][ADD] attachment_log

Open geomer198 opened this issue 11 months ago • 13 comments

This module adds the following features for attachments:

  • Displays the date and time when each attachment was added under the attachment file
  • Records chatter messages showing which user linked or unlinked files to attachments

geomer198 avatar Jan 09 '25 17:01 geomer198

Just noticed that I don't seem to be able to attach a file in a message (upload doesn't complete) when the feature is activated (tested in Runboat). Can you please check?

image

yostashiro avatar Jan 19 '25 23:01 yostashiro

Just noticed that I don't seem to be able to attach a file in a message (upload doesn't complete) when the feature is activated (tested in Runboat). Can you please check?

Hi @yostashiro! Thank you for noticing that! Will fix.

ivs-cetmix avatar Jan 21 '25 10:01 ivs-cetmix

Just noticed that I don't seem to be able to attach a file in a message (upload doesn't complete) when the feature is activated (tested in Runboat). Can you please check?

image

Thank you for your comment. I have tested your problem on runboat and everything works correctly.

geomer198 avatar Mar 03 '25 21:03 geomer198

Hi @yostashiro could you please check again on the runboat?

ivs-cetmix avatar Mar 16 '25 13:03 ivs-cetmix

Took a quick look in runboat and noticed a couple of things:

1/ When I attach a file directly to the thread (not via send message or log note), the user and date information doesn't seem to be assigned to the attachment.

image

2/ The assigned date seems to show in UTC. The best would be to show it in user's timezone.

image

If these are as intended, we may want to update the README to mention these?

yostashiro avatar Mar 17 '25 09:03 yostashiro

@yostashiro Could you please check again?

geomer198 avatar Mar 25 '25 08:03 geomer198

Merging based on the reviews. /ocabot merge nobump

rvalyi avatar Mar 26 '25 02:03 rvalyi

/ocabot merge nobump

rvalyi avatar Mar 27 '25 01:03 rvalyi

Hi @rvalyi , looks like the merge process has stuck here. @sbidoul could you please have a look too?

ivs-cetmix avatar Mar 31 '25 06:03 ivs-cetmix

/ocabot merge nobump

ivs-cetmix avatar May 01 '25 11:05 ivs-cetmix

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-3161-by-ivs-cetmix-bump-nobump, awaiting test results.

OCA-git-bot avatar May 01 '25 11:05 OCA-git-bot

@ivs-cetmix your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3161-by-ivs-cetmix-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar May 01 '25 11:05 OCA-git-bot

@geomer198 Can you rebase de code to retry the tests?

christian-ramos-tecnativa avatar May 08 '25 11:05 christian-ramos-tecnativa

@geomer198 Can you rebase de code to retry the tests?

Done!

geomer198 avatar Jun 14 '25 20:06 geomer198

@Christian-RB Could you please proceed with the merge?

Bearnard21 avatar Jun 20 '25 08:06 Bearnard21

@ivs-cetmix Can you retry the merge command? Thanks in advance

christian-ramos-tecnativa avatar Jun 20 '25 11:06 christian-ramos-tecnativa

/ocabot merge nobump

ivs-cetmix avatar Jun 20 '25 11:06 ivs-cetmix

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-3161-by-ivs-cetmix-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 20 '25 11:06 OCA-git-bot

Congratulations, your PR was merged at c89a36e6eab4d99c8ce210fec823565975f4f32a. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 20 '25 11:06 OCA-git-bot