server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[FIX] sentry: Fix deprecated usage of text_type

Open hnavarro-kernet opened this issue 1 year ago • 5 comments

See original migration for reference: https://github.com/getsentry/sentry-python/commit/2d354c7e4f9536f43d64399ac749bc6218a382a0

hnavarro-kernet avatar Nov 02 '24 01:11 hnavarro-kernet

@hnavarro-kernet could you rebase?

MiquelRForgeFlow avatar Dec 12 '24 17:12 MiquelRForgeFlow

Should be rebased now @MiquelRForgeFlow

hnavarro-kernet avatar Feb 02 '25 23:02 hnavarro-kernet

Run pre-commit.

MiquelRForgeFlow avatar Feb 03 '25 09:02 MiquelRForgeFlow

Sorry! Pre-commit successful, waiting for tests/test now.

hnavarro-kernet avatar Feb 03 '25 11:02 hnavarro-kernet

All 4 PRs depend on each other I guess:

  • https://github.com/OCA/server-tools/pull/3103
  • https://github.com/OCA/server-tools/pull/3104
  • https://github.com/OCA/server-tools/pull/3105
  • https://github.com/OCA/server-tools/pull/3106

So maybe merge them into one?

Maybe backport from this one that should have fixed all the issues?

  • https://github.com/OCA/server-tools/pull/3174

If a maintainer with approval rights want to tell me what to do I'd be happy to, if not, this has been on prod since the PR was opened so I'm not going to fight the tests.

hnavarro-kernet avatar Feb 13 '25 07:02 hnavarro-kernet