server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard
verified publisher icon OCA

[18.0][MIG] scheduler_error_mailer

Open astirpe opened this issue 1 year ago • 11 comments

astirpe avatar Oct 17 '24 07:10 astirpe

/ocabot migration scheduler_error_mailer

StefanRijnhart avatar Feb 07 '25 09:02 StefanRijnhart

@StefanRijnhart I will, thank you!

astirpe avatar Feb 07 '25 11:02 astirpe

rebased

astirpe avatar Feb 07 '25 14:02 astirpe

@astirpe are you still working on this?

CRogos avatar Apr 10 '25 14:04 CRogos

@CRogos Thank you for your review! I'm very busy with projects, I could continue with this when I can find some time. Sorry

astirpe avatar Apr 10 '25 15:04 astirpe

@CRogos Is it alright for you now?

StefanRijnhart avatar Apr 16 '25 08:04 StefanRijnhart

Oh, we're getting errors because the mail template body is no longer valid due to the ir.cron datamodel changes. @astirpe would you consider taking https://github.com/astirpe/server-tools/pull/1?

StefanRijnhart avatar Apr 16 '25 09:04 StefanRijnhart

Thank you @StefanRijnhart !

astirpe avatar Apr 16 '25 09:04 astirpe

Apologies @astirpe, it turns out that in migrated databases the template_fs of the template might not be set, so here is https://github.com/astirpe/server-tools/pull/2. And please rebase and squash all migration commits as @CRogos suggests.

StefanRijnhart avatar Apr 16 '25 10:04 StefanRijnhart

I will do the rebase and squash, thanks!

astirpe avatar Apr 16 '25 10:04 astirpe

@astirpe are you still working on this?

CRogos avatar May 06 '25 14:05 CRogos

There are still some commits which should be squashed:

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate image (there are more these are only examples)

CRogos avatar May 12 '25 08:05 CRogos

@astirpe could you do the squashing? I think we can merge afterwards.

CRogos avatar Jun 26 '25 16:06 CRogos

@CRogos squashed, thanks!

astirpe avatar Jun 27 '25 06:06 astirpe

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 27 '25 07:06 OCA-git-bot

/ocabot merge nobump

StefanRijnhart avatar Jun 27 '25 07:06 StefanRijnhart

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 18.0-ocabot-merge-pr-3084-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 27 '25 07:06 OCA-git-bot

Congratulations, your PR was merged at 4d928292cc1a3f148adeba1f06218b56c358a9eb. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 27 '25 07:06 OCA-git-bot