server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[17.0][MIG] fetchmail_notify_error_to_sender, fetchmail_notify_error_to_sender_test: Migration to 17.0

Open BT-cjimeno opened this issue 1 year ago • 2 comments

fetchmail_notify_error_to_sender: Migration from 15.0 fetchmail_notify_error_to_sender_test: Migration from 14.0

Fixes the bug found here

Modified the tests to include all the raise conditions.

BT-cjimeno avatar Jul 05 '24 06:07 BT-cjimeno

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 10 '24 06:07 OCA-git-bot

Hi @PieterPaulussen, sorry for the late reply and thx for the review, I agree with all your points.

I am not sure if they can all go in the same commit as the migration, or if I need to use a different commit and syntax for the new commit message, since they are improvements not directly related with the migration but with the module.

BT-cjimeno avatar Aug 19 '24 14:08 BT-cjimeno

I think it's perfectly fine to address @PieterPaulussen's comments in a new commit in the same PR

hbrunn avatar Dec 27 '24 09:12 hbrunn

Thanks for the updates @BT-cjimeno

PieterPaulussen avatar Dec 27 '24 10:12 PieterPaulussen

/ocabot merge nobump

hbrunn avatar Dec 27 '24 10:12 hbrunn

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-2982-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot avatar Dec 27 '24 10:12 OCA-git-bot

Congratulations, your PR was merged at 39147d117f71b548517b47f9a9385763c495cc60. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Dec 27 '24 11:12 OCA-git-bot