server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[16.0][FIX] base_name_search_improved: don't patch abstract models

Open StefanRijnhart opened this issue 1 year ago • 1 comments

When applying monkey patches, we want to skip abstract models because patching those may mess up the inheritance. An example of this is ir.model which is assigned the studio mixin using inherit = ['studio.mixin', 'ir.model']. If the mixin itself is patched, and the method is overridden once again (in, say, enterprise 15's documents_spreadsheet), the super() method called in that override is the patched version of studio.mixin rather than the override of ir.model in the base module, which is now skipped entirely.

StefanRijnhart avatar Jul 01 '24 14:07 StefanRijnhart

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 06 '24 15:07 OCA-git-bot

/ocabot merge patch

pedrobaeza avatar Oct 09 '24 15:10 pedrobaeza

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-2977-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot avatar Oct 09 '24 15:10 OCA-git-bot

Congratulations, your PR was merged at a787ad2345d654d2e2b634bb66aaffd3c3ca4f99. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 09 '24 15:10 OCA-git-bot