server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[17.0][MIG] auto_backup: Migration to 17.0

Open rpinset opened this issue 1 year ago • 8 comments

second attempt at https://github.com/OCA/server-tools/pull/2894

rpinset avatar Jun 28 '24 08:06 rpinset

@CRogos all the checks are green but I followed the commands on this page for the translations but it didn't work https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

rpinset avatar Jun 28 '24 08:06 rpinset

I use the vscode terminal:

git config --global --add rebase.instructionFormat "(%an <%ae>) %s" git rebase -i origin/17.0 // change "pick" by "f" where needed, and save + close the file. git push -f

CRogos avatar Jun 28 '24 08:06 CRogos

/ocabot migration auto_backup

gurneyalex avatar Jul 02 '24 10:07 gurneyalex

It appears the build task has stalled...

Crazor avatar Sep 03 '24 06:09 Crazor

It appears the build task has stalled...

It does seems stuck, can anyone with privileges please check on this?

litmount avatar Sep 09 '24 19:09 litmount

@rpinset

Please add the Python package to the requirements.txt file as shown in the attached screenshot. image Currently, we are using this PR, but we are encountering conflicts in the requirements.txt file while running gitaggregate

SodexisTeam avatar Sep 25 '24 10:09 SodexisTeam

@rpinset When can we expect this PR to be merged?

SodexisTeam avatar Sep 25 '24 10:09 SodexisTeam

Please add the Python package to the requirements.txt file as shown in the attached screenshot. image Currently, we are using this PR, but we are encountering conflicts in the requirements.txt file while running gitaggregate

Hello @SodexisTeam , I added "pygount" in Requirements.txt but I don't know what external_dependencies require it. I already use it too. But I'm struggling with the OCA CI, maybe my environment is not optimal and I should redo it. All tests are OK @gurneyalex can you try merge ?

rpinset avatar Sep 26 '24 07:09 rpinset

It does not work correctly, try to create a directory per backup.

If the path is backups Create a file for each backup respecting the path and not trying to create a directory for each backup.

percevaq avatar Oct 08 '24 20:10 percevaq

It does not work correctly, try to create a directory per backup.

If the path is backups Create a file for each backup respecting the path and not trying to create a directory for each backup.

Hello @percevaq There has been no code change at this level since v16 and the v17 installation is functional for me. Does your comment only come from reading the code or from tests? image Have a good day

rpinset avatar Nov 26 '24 22:11 rpinset

@gurneyalex can you try merge ?

@gurneyalex All tests are OK can you try merge ?

rpinset avatar Nov 26 '24 22:11 rpinset

The commit history is still not OK: image

Sorry @CRogos for having commits in September because Bots find a difference between my branch and the destination. I will take back your git commands minimizing commits, when I have more time to take the head. It is a particular use.

My branch works, if someone is more used to it, fork, pull request and inform here.

rpinset avatar Nov 30 '24 07:11 rpinset

@CRogos @rpinset When can we expect this PR to be merged?

Thanks in advance.

lmonterogarcia avatar Jan 09 '25 10:01 lmonterogarcia

As this PR seems to be stuck I have created a new one https://github.com/OCA/server-tools/pull/3180 retaining @rpinset authorship and fixing the commit history @CRogos. I’d appreciate your collaboration there

I understand that the SFTP connection is made with a username and password or with a username and key. I have tried it both ways, but it throws the same key error even though I don't use a key for the sftp connection. backup1 backup2

This is because the remote needs to be in the known_hosts list. The pysft library let you add extra information as a known_host entry IMO it would be nice to implement that as a new field in the configuration