server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard
verified publisher icon OCA

[14.0][FIX] base_name_search_improved: deal with query objects

Open chienandalu opened this issue 1 year ago • 2 comments

In smart searches we're joining two _search results which normally will be a Query object. We need to resolve those queries in order to join the results.

cc @Tecnativa TT48444

please review @pedrobaeza

this could supersed https://github.com/OCA/server-tools/pull/2820

chienandalu avatar May 14 '24 08:05 chienandalu

I can't test this module. Model and Model Description is readonly. Can you check or help me please?

Selection_011

Saran440 avatar May 14 '24 09:05 Saran440

@Saran440 Why don't you use an existing model?

chienandalu avatar May 14 '24 09:05 chienandalu

/ocabot merge patch

StefanRijnhart avatar Jul 01 '24 15:07 StefanRijnhart

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-2940-by-StefanRijnhart-bump-patch, awaiting test results.

OCA-git-bot avatar Jul 01 '24 15:07 OCA-git-bot

Congratulations, your PR was merged at 5eba3560073730109c6b22d668bf7a3a690b091f. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 01 '24 15:07 OCA-git-bot