server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[16.0][IMP] attachment_synchronize: add additional error hook

Open kevinkhao opened this issue 1 year ago • 2 comments

this can be useful in case for example if you want to link an attachment.queue that raised an error, to a record. It dodges the restriction with the rollback. As a caveat, it cannot be added to the manual run button and preserve the raise and the hook in a simple way. However, chances are it will already have been run and linked to the record

kevinkhao avatar Mar 07 '24 13:03 kevinkhao

Hi @sebastienbeau, @florian-dacosta, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Mar 07 '24 13:03 OCA-git-bot

Can you tell more about your use case ? Anyway, why not LGTM

In conjunction with https://github.com/OCA/server-tools/pull/2875#pullrequestreview-2020069245

I add a hook to link the attachment.queue to whatever record it was trying to process.

For example, in my case 1 attachment queue fills the "done" quantities of 1 picking. If there is an error, for example I try to set the quantities on a product that shouldn't be in that picking, I still link the attachment queue to the picking. Something like

`

def _additional_error_hook(self, e):

    if type(e) is WmsImportException:

        e.record.track_model_import(self)

    return super()._additional_error_hook(e)

`

kevinkhao avatar Apr 24 '24 16:04 kevinkhao