OCA
[17.0][MIG] base_name_search_improved: Migration to 17.0
Same comment as in https://github.com/OCA/server-tools/pull/2833: any idea why _search_smart_search doesn't seem to receive coverage?
Hi! I was wondering - is there still ongoing work on this? Does it work functionally?
@thomaspaulb Hey! I really I don't know how to solve the problem of coverage because it is working fine in my computer
@thomaspaulb Hey! I really I don't know how to solve the problem of coverage because it is working fine in my computer
https://en.wikipedia.org/wiki/Code_coverage
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump, awaiting test results.
@StefanRijnhart The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-tools --branch 17.0 --addons-dir /tmp/tmp5uc11ybe --commit failed with output:
/tmp/tmp5uc11ybe/base_name_search_improved/README.rst:87: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
return self.main(*args, **kwargs)
File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
check_rst(readme_filename)
File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
publish_file(
File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 422, in publish_file
output, publisher = publish_programmatically(
File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 722, in publish_programmatically
output = publisher.publish(enable_exit_status=enable_exit_status)
File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 234, in publish
self.document = self.reader.read(self.source, self.parser,
File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 70, in read
self.parse()
File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 76, in parse
self.parser.parse(self.input, document)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
self.statemachine.run(inputlines, document, inliner=self.inliner)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 169, in run
results = StateMachineWS.run(self, input_lines, input_offset,
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
context, next_state, result = self.check_line(
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
return method(match, context, next_state)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 3024, in text
self.section(title.lstrip(), source, style, lineno + 1, messages)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
self.new_subsection(title, lineno, messages)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
newabsoffset = self.nested_parse(
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
state_machine.run(block, input_offset, memo=self.memo,
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
results = StateMachineWS.run(self, input_lines, input_offset)
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
context, next_state, result = self.check_line(
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
return method(match, context, next_state)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2785, in underline
self.section(title, source, style, lineno - 1, messages)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
self.new_subsection(title, lineno, messages)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
newabsoffset = self.nested_parse(
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
state_machine.run(block, input_offset, memo=self.memo,
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
results = StateMachineWS.run(self, input_lines, input_offset)
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
context, next_state, result = self.check_line(
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
return method(match, context, next_state)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2355, in explicit_markup
nodelist, blank_finish = self.explicit_construct(match)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2367, in explicit_construct
return method(self, expmatch)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2085, in substitution_def
self.document.note_substitution_def(
File "/ocamt/lib/python3.8/site-packages/docutils/nodes.py", line 1550, in note_substitution_def
msg = self.reporter.error(
File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 231, in error
return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 197, in system_message
raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmp5uc11ybe/base_name_search_improved/README.rst:87: (ERROR/3) Duplicate substitution definition name: "image1".
Huh, looks like the README compilation is struggling with three images in two snippets. Can you play around to see if you can get it to work?
On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump, awaiting test results.
@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@StefanRijnhart Hey Stefan! some track_manager tests are failing. I was checking that.
@thomaspaulb Hey! I tried to replicate the issue locally, but I couldn't.
@StefanRijnhart Hi Stefan! I just corrected this PR. Could you please review it? Thanks in advance! Regards
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump, awaiting test results.
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump, awaiting test results.
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump, awaiting test results.
Not sure why merging fails. First I got
Pushing changes...
To https://github.com/OCA/server-tools
! [rejected] 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump -> 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump (fetch first)
error: failed to push some refs to 'https://github.com/OCA/server-tools'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
because there was an older merge branch lying around. I deleted that branch, and now I get
Pushing changes...
To https://github.com/OCA/server-tools
! [remote rejected] 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump -> 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump (cannot lock ref 'refs/heads/17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump': is at 7e5d48cee274c75bc49d0716f5ed117943647f68 but expected 00fbb489354808b96eb89a91cdec09ad1b4e364c)
error: failed to push some refs to 'https://github.com/OCA/server-tools'
@pedrobaeza do you know how to get this unstuck?
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-2831-by-pedrobaeza-bump-nobump, awaiting test results.
@pedrobaeza @StefanRijnhart Hi! Just wanted to check if there are any changes you'd like me to make in the PR, or if there's anything else I can do to assist. Thanks in advance!
@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.