server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[13.0][FIX]database_cleanup: Don't purge by default

Open thomaspaulb opened this issue 2 years ago • 5 comments

Forward port of https://github.com/OCA/server-tools/pull/1978

  • [ ] Depends on https://github.com/OCA/server-tools/pull/2860

thomaspaulb avatar Dec 03 '23 20:12 thomaspaulb

@hbrunn Gosh, tour tests are failing on a line in base_remote, which asserts something unless test_enable = True; but when the tour calls the backend, test_enable apparently is False. Have you encountered this before, and/or have an idea how to fix?

thomaspaulb avatar Feb 23 '24 17:02 thomaspaulb

not encountered before. Code having to detect if it's running in tests very often is a problem with the tests or with the code anyways. One of them should be rewritten, or if that's not feasible/possible, the module isolated into a rebel group

hbrunn avatar Feb 26 '24 10:02 hbrunn

Trying a merge /ocabot merge patch

dreispt avatar Apr 23 '24 14:04 dreispt

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-2773-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot avatar Apr 23 '24 14:04 OCA-git-bot

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-2773-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Apr 23 '24 14:04 OCA-git-bot