server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[16.0][MIG] base_changeset

Open MrGigSolutions opened this issue 2 years ago • 4 comments

Disclaimer: as noted as a 'Known Issue' in the README, the adaptation to Odoo 16's javascript was done in a way that support for showing pending changes for fields without label is no longer present. It was already hardly functional in 15.0 (not working for the partner's inline address fields for instance) and erratic in 14.0 (not working for the partner's inline address fields when no value was set yet).

MrGigSolutions avatar Jun 29 '23 12:06 MrGigSolutions

/ocabot migration base_changeset

StefanRijnhart avatar Jun 29 '23 13:06 StefanRijnhart

When logging in with user demo, the access restrictions on ir.model cause an exception:

  File "/home/odoo/16.0/parts/odoo/odoo/api.py", line 409, in _model_create_multi
    return create(self, [arg])
  File "/home/odoo/16.0/parts/server-tools/base_changeset/models/base.py", line 80, in create
    if self._changeset_disabled():
  File "/home/odoo/16.0/parts/server-tools/base_changeset/models/base.py", line 111, in _changeset_disabled
    if self._name not in self.models_to_track_changeset():
  File "<decorator-gen-120>", line 2, in models_to_track_changeset
  File "/home/odoo/16.0/parts/odoo/odoo/tools/cache.py", line 90, in lookup
    value = d[key] = self.method(*args, **kwargs)
  File "/home/odoo/16.0/parts/server-tools/base_changeset/models/base.py", line 71, in models_to_track_changeset
    models = self.env["changeset.field.rule"].search([]).mapped("model_id.model")
  File "/home/odoo/16.0/parts/odoo/odoo/models.py", line 5362, in mapped
    recs = recs._fields[name].mapped(recs)
  File "/home/odoo/16.0/parts/odoo/odoo/fields.py", line 1278, in mapped
    self.__get__(first(remaining), type(remaining))
  File "/home/odoo/16.0/parts/odoo/odoo/fields.py", line 1187, in __get__
    record._fetch_field(self)
  File "/home/odoo/16.0/parts/odoo/odoo/models.py", line 3162, in _fetch_field
    self._read(fnames)
  File "/home/odoo/16.0/parts/odoo/odoo/models.py", line 3172, in _read
    self.check_access_rights('read')
  File "/home/odoo/16.0/parts/odoo/odoo/models.py", line 3432, in check_access_rights
    return self.env['ir.model.access'].check(self._name, operation, raise_exception)
  File "/home/odoo/16.0/parts/odoo/odoo/addons/base/models/ir_model.py", line 1893, in check
    raise AccessError(msg)
odoo.exceptions.AccessError: You are not allowed to access 'Models' (ir.model) records.

StefanRijnhart avatar Jun 29 '23 13:06 StefanRijnhart

Hi @StefanRijnhart I think this PR is ready to be merged :)

houssine78 avatar May 15 '24 09:05 houssine78

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 15 '24 09:05 OCA-git-bot

/ocabot merge nobump

hbrunn avatar May 24 '24 16:05 hbrunn

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-2663-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot avatar May 24 '24 16:05 OCA-git-bot

Congratulations, your PR was merged at eb36811b8bcd40a31922f1f84f158cc4d570d871. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 24 '24 16:05 OCA-git-bot