server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[14.0][ADD] base_changeset_tier_validation: New module

Open victoralmau opened this issue 2 years ago • 6 comments

Misc changes from base_changeset:

  • [x] Change development_status to Beta.
  • [x] Improve _changeset_disabled() method with self.env.su
  • [x] Remove <data> tag from groups.xml
  • [x] Add Admin user to Changeset Configuration (group_changeset_manager) group
  • [x] Changes to the form view of record.changeset for better inheritance
  • [x] Fix add_changeset() method with validator_group_ids

New module

Extra changes:

  • [x] Hide popover changes buttons if there is a review linked to the changeset. TT45803
  • [x] Change tier_validation_label to pending_review_ids. TT45805
  • [x] Add Review Summary to changeset form view
  • [x] Custom tree view (review_ids) to changeset form view.

Locked by:

  • [x] base_tier_validation: https://github.com/OCA/server-ux/pull/659
  • [x] base_tier_validation: https://github.com/OCA/server-ux/pull/714

Please @pedrobaeza and @CarlosRoca13 can you review it (for now, it is only a proof of concept)?

@Tecnativa TT43351

victoralmau avatar May 17 '23 11:05 victoralmau

Hi @astirpe, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar May 17 '23 11:05 OCA-git-bot

Ping @pedrobaeza

victoralmau avatar Jun 21 '23 08:06 victoralmau

Now, it's ready to review. @pedrobaeza and @CarlosRoca13

victoralmau avatar Jun 23 '23 11:06 victoralmau

@victoralmau can you please fix the typo on module name? Changest > Changeset

astirpe avatar Jun 23 '23 11:06 astirpe

@victoralmau can you please fix the typo on module name? Changest > Changeset

Sorry, already changed.

victoralmau avatar Jun 23 '23 11:06 victoralmau

Currently there is an error when trying to access the changeset from the revisions table at the bottom.

If we have web_tree_many2one_clickable installed and we try to access the changeset, the whole breadcrumb is lost. Before: antes

This will be resolved with https://github.com/OCA/server-ux/pull/716 change. After: despues

victoralmau avatar Sep 05 '23 06:09 victoralmau