server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[12.0][FIX] excel_import_excel: fix adding new row in excel for pre-defined row and add extend attribute

Open AungKoKoLin1997 opened this issue 2 years ago • 8 comments

Before this commit, if we export excel with multiple rows (eg.sale order line) that has pre-defined row with attributes in excel file(eg. line rule and font), the first output row will only affect the attributes and the attributes of the rest is none because the system insert new rows after added the first row. After this commit, the above problem will be solved and inserting new row will work when we enable extend attribute (reference from v13.0).

Please see the reference. This is the default excel file for exporting. sale_order.xlsx

This is the export excel before this commit. SO007(8).xlsx

This is the export excel after commit. SO007(20).xlsx

@qrtl

AungKoKoLin1997 avatar Jan 15 '23 14:01 AungKoKoLin1997

Hi @kittiu, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jan 15 '23 14:01 OCA-git-bot

@kittiu Can you please review this PR?

AungKoKoLin1997 avatar Jan 15 '23 14:01 AungKoKoLin1997

Function review: it works as expected. What is this Travis error?

kanda999 avatar Jan 16 '23 07:01 kanda999

What is this Travis error?

@kanda999 I don't know what is the reason why travis failed? I think we need to change CI from travis to github in 12.0 branch.

AungKoKoLin1997 avatar Jan 16 '23 08:01 AungKoKoLin1997

I think we need to change CI from travis to github in 12.0 branch.

@AungKoKoLin1997 Please work on this yourself if you can. Expect to have several hiccups in the process. See how it went for 13.0 here: https://github.com/OCA/server-tools/pull/2518

yostashiro avatar Jan 16 '23 08:01 yostashiro

@AungKoKoLin1997 Maybe rebase this as well

thomaspaulb avatar Feb 10 '24 14:02 thomaspaulb

@thomaspaulb Done!

AungKoKoLin1997 avatar Feb 10 '24 14:02 AungKoKoLin1997

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Nov 02 '25 12:11 github-actions[bot]